Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls_cert_request not recreated when private_key_pem changes #257

Merged
merged 5 commits into from
Aug 19, 2022
Merged

tls_cert_request not recreated when private_key_pem changes #257

merged 5 commits into from
Aug 19, 2022

Conversation

bendbennett
Copy link
Contributor

@bendbennett bendbennett commented Aug 11, 2022 •
edited
Loading

@bendbennett bendbennett requested a review from a team as a code owner August 11, 2022 12:16
bflad
bflad approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (once Taint actually works) 🚀

internal/provider/common.go Outdated Show resolved Hide resolved
bendbennett and others added 4 commits August 19, 2022 13:21
@bendbennett
Fix requiresReplaceIfStateContainsPEMString function so that the rege…
89650a3 
…xp used identifies that BEGIN and END text can contain spaces, for instance -----BEGIN RSA PRIVATE KEY----- (#255)
@bendbennett @bflad
Apply suggestions from code review
d245cba 
Co-authored-by: Brian Flad <bflad417@gmail.com>
@bendbennett
Bump dependencies and fix tests (#255)
100c4e8
@bendbennett
Updating CHANGELOG.md (#255)
9da82fa
@bendbennett bendbennett force-pushed the bendbennett/issues-255 branch from 15d5fc2 to 9da82fa Compare August 19, 2022 12:34
bflad
bflad approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

CHANGELOG.md Outdated
@@ -1,3 +1,11 @@
## 4.0.2 (July 25, 2022)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Date bump on release 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nudge. Have changed to unreleased for now.

@bendbennett bendbennett merged commit 0062549 into main Aug 19, 2022
@bendbennett bendbennett deleted the bendbennett/issues-255 branch August 19, 2022 14:50
@bendbennett bendbennett added this to the v4.0.2 milestone Aug 22, 2022
@bendbennett bendbennett mentioned this pull request Aug 26, 2022
Closed
1 task
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
bug dependencies size/M
Projects
None yet
Milestone
v4.0.2
Development

Successfully merging this pull request may close these issues.

tls_cert_request not recreated when private_key_pem changes
2 participants
@bendbennett @bflad