Skip to content

Commit

Permalink
Merge pull request #10733 from hashicorp/f-remove-deprecated-param-group
Browse files Browse the repository at this point in the history
provider/aws: Removed deprecated parameter group from RDS Cluster
  • Loading branch information
catsby authored Dec 14, 2016
2 parents 1d794d3 + 4007fd2 commit 89c328a
Showing 1 changed file with 0 additions and 21 deletions.
21 changes: 0 additions & 21 deletions builtin/providers/aws/resource_aws_rds_cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,16 +64,6 @@ func resourceAwsRDSCluster() *schema.Resource {
Computed: true,
},

// TODO: remove parameter_group_name
// See https://github.com/hashicorp/terraform/issues/7046
// Likely need migration to remove from state
"parameter_group_name": {
Type: schema.TypeString,
Optional: true,
Computed: true,
Deprecated: "Use db_cluster_parameter_group_name instead. This attribute will be removed in a future version",
},

"db_cluster_parameter_group_name": {
Type: schema.TypeString,
Optional: true,
Expand Down Expand Up @@ -326,10 +316,6 @@ func resourceAwsRDSClusterCreate(d *schema.ResourceData, meta interface{}) error
createOpts.DBSubnetGroupName = aws.String(attr.(string))
}

if attr, ok := d.GetOk("parameter_group_name"); ok {
createOpts.DBClusterParameterGroupName = aws.String(attr.(string))
}

if attr, ok := d.GetOk("db_cluster_parameter_group_name"); ok {
createOpts.DBClusterParameterGroupName = aws.String(attr.(string))
}
Expand Down Expand Up @@ -438,7 +424,6 @@ func resourceAwsRDSClusterRead(d *schema.ResourceData, meta interface{}) error {

d.Set("cluster_identifier", dbc.DBClusterIdentifier)
d.Set("db_subnet_group_name", dbc.DBSubnetGroup)
d.Set("parameter_group_name", dbc.DBClusterParameterGroup)
d.Set("db_cluster_parameter_group_name", dbc.DBClusterParameterGroup)
d.Set("endpoint", dbc.Endpoint)
d.Set("engine", dbc.Engine)
Expand Down Expand Up @@ -518,12 +503,6 @@ func resourceAwsRDSClusterUpdate(d *schema.ResourceData, meta interface{}) error
requestUpdate = true
}

if d.HasChange("parameter_group_name") {
d.SetPartial("parameter_group_name")
req.DBClusterParameterGroupName = aws.String(d.Get("parameter_group_name").(string))
requestUpdate = true
}

if d.HasChange("db_cluster_parameter_group_name") {
d.SetPartial("db_cluster_parameter_group_name")
req.DBClusterParameterGroupName = aws.String(d.Get("db_cluster_parameter_group_name").(string))
Expand Down

0 comments on commit 89c328a

Please sign in to comment.