Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws: Add api_gateway_binary_media_types resource #10696

Closed
lenaten opened this issue Dec 13, 2016 · 8 comments
Closed

provider/aws: Add api_gateway_binary_media_types resource #10696

lenaten opened this issue Dec 13, 2016 · 8 comments
Labels
enhancement provider/aws

Comments

@lenaten
Copy link

lenaten commented Dec 13, 2016

Amazon announced they add the ability to send and receive binary data through API endpoints hosted on Amazon API Gateway. It's could be very useful for image processing with lambda.

The value of api_gateway_binary_media_types should be a list of strings (HTTP Content Type). For example:

  • image/jpeg
  • image/png
@jmettes
Copy link
Contributor

jmettes commented Dec 14, 2016 •
edited
Loading

I'm giving this a crack - almost have it working I think. Hopefully will put in pull request soon.

Edit: Got it working. Need to clean it up a bit and add some tests, but will put in a PR tomorrow.

@jmettes jmettes mentioned this issue Dec 16, 2016
Merged
@stack72
Copy link
Contributor

stack72 commented Dec 16, 2016

Closed via #10776 - thanks to @jmettes :)

@stack72 stack72 closed this as completed Dec 16, 2016
@lenaten
Copy link
Author

lenaten commented Dec 16, 2016

Great! Thanks @jmettes!

@advdv
Copy link

advdv commented Dec 29, 2016

Thanks for implementing this but I would like to reopen this as it seems the aws_integration_response also requires a content_handling attribute: http://docs.aws.amazon.com/apigateway/api-reference/resource/integration-response/ .

Would it be as simple for you @jmettes as to copy the logic from aws_integration ?

@przemos
Copy link

przemos commented Jan 3, 2017

+1 for reopen.

@stack72
Copy link
Contributor

stack72 commented Jan 3, 2017

Reopening as this was only partially added

@stack72 stack72 reopened this Jan 3, 2017
@stack72 stack72 mentioned this issue Jan 3, 2017
Closed
stack72 added a commit that referenced this issue Jan 3, 2017
@stack72
provider/aws: Add support for content_handling to
610e152 
aws_api_gateway_integration_response

This continues the work carried out in #10696

```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAPIGatewayIntegrationResponse_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/01/03 14:18:46 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v
-run=TestAccAWSAPIGatewayIntegrationResponse_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayIntegrationResponse_basic
--- PASS: TestAccAWSAPIGatewayIntegrationResponse_basic (57.33s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws57.352s
```
@stack72 stack72 mentioned this issue Jan 3, 2017
Merged
@stack72
Copy link
Contributor

stack72 commented Jan 3, 2017

Folks, I have just opened #11002 that will take care of the rest of this request

@stack72 stack72 closed this as completed Jan 3, 2017
stack72 added a commit that referenced this issue Jan 9, 2017
@stack72
provider/aws: Add support for content_handling to (#11002)
ba41375 
aws_api_gateway_integration_response

This continues the work carried out in #10696

```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAPIGatewayIntegrationResponse_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/01/03 14:18:46 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v
-run=TestAccAWSAPIGatewayIntegrationResponse_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayIntegrationResponse_basic
--- PASS: TestAccAWSAPIGatewayIntegrationResponse_basic (57.33s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws57.352s
```
@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement provider/aws
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@advdv @stack72 @jmettes @lenaten @przemos