Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws: Guard against nil change output #10798

Merged
merged 1 commit into from
Dec 28, 2016
Merged

provider/aws: Guard against nil change output #10798

merged 1 commit into from
Dec 28, 2016

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Dec 16, 2016 •
edited
Loading

Should also fix #9514

TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSRoute53Zone_ -timeout 120m
=== RUN   TestAccAWSRoute53Zone_importBasic
--- PASS: TestAccAWSRoute53Zone_importBasic (46.44s)
=== RUN   TestAccAWSRoute53Zone_basic
--- PASS: TestAccAWSRoute53Zone_basic (50.71s)
=== RUN   TestAccAWSRoute53Zone_forceDestroy
--- PASS: TestAccAWSRoute53Zone_forceDestroy (463.16s)
=== RUN   TestAccAWSRoute53Zone_updateComment
--- PASS: TestAccAWSRoute53Zone_updateComment (68.32s)
=== RUN   TestAccAWSRoute53Zone_private_basic
--- PASS: TestAccAWSRoute53Zone_private_basic (60.54s)
=== RUN   TestAccAWSRoute53Zone_private_region
--- PASS: TestAccAWSRoute53Zone_private_region (63.45s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    752.652s

@catsby catsby mentioned this pull request Dec 16, 2016
Closed
stack72
stack72 approved these changes Dec 17, 2016
View reviewed changes
Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stack72 stack72 merged commit b6a54bb into master Dec 28, 2016
@stack72 stack72 deleted the b-aws-check-nil-r53-zone branch December 28, 2016 16:45
Mongey pushed a commit to Mongey/terraform that referenced this pull request Jan 6, 2017
@catsby @Mongey
provider/aws: Guard against nil change output (hashicorp#10798)
7086aa8
bflad added a commit to hashicorp/terraform-provider-aws that referenced this pull request Apr 2, 2020
@bflad
resource/aws_route53_zone: Guard against missing ChangeInfo during cr…
6d6fca9 
…eation

Reference: #8370
Reference: #12361
Reference: hashicorp/terraform#10798

Prevent a crash with non-compliant Route 53 APIs during creation, e.g. LocalStack. This continues best effort support by adding object reference safety, which we should be doing anyways. This change skips synchronization checking rather than raising an error, which seems like the correct and operator friendly behavior in this situation.

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSRoute53Zone_disappears (48.02s)
--- PASS: TestAccAWSRoute53Zone_basic (51.48s)
--- PASS: TestAccAWSRoute53Zone_DelegationSetID (56.24s)
--- PASS: TestAccAWSRoute53Zone_multiple (57.08s)
--- PASS: TestAccAWSRoute53Zone_Comment (63.31s)
--- PASS: TestAccAWSRoute53Zone_Tags (79.33s)
--- PASS: TestAccAWSRoute53Zone_VPC_Single (99.31s)
--- PASS: TestAccAWSRoute53Zone_VPC_Multiple (179.74s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod (189.14s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy (189.54s)
--- PASS: TestAccAWSRoute53Zone_VPC_Updates (265.16s)
```
@bflad bflad mentioned this pull request Apr 2, 2020
Merged
@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stack72 stack72 stack72 approved these changes

Assignees
No one assigned
Labels
bug provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash during destroy
2 participants
@catsby @stack72