Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Update the ignoring of AWS specific tags #14321

Merged
merged 1 commit into from
May 9, 2017

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented May 9, 2017

We were too greedy with the AWS specific tags ignore function - we
basically were ignoring anything starting with aws rather than just
using aws:

Fixes: #14308
Fixes: #14247

We were too greedy with the AWS specific tags ignore function - we
basically were ignoring anything starting with `aws` rather than just
using `aws:`

Fixes: #14308
Fixes: #14247
Copy link
Contributor

@apparentlymart apparentlymart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think strings.HasPrefix(..., "aws:") would be easier to read and faster, but not a big deal.

@grubernaut
Copy link
Contributor

grubernaut commented May 9, 2017

Agree with @apparentlymart here. Also a lot of these functions look the same, any way we can refactor these specific functions into a more generic approach here? So if we need to update the filters again, we don't have to touch 18 different files.

@stack72
Copy link
Contributor Author

stack72 commented May 9, 2017

@grubernaut we can't because of generics - we pass a specific type to the function

Let's merge and then we can try and work out a better design?

@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants