-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/digitalocean: Fixing the DigitalOcean Droplet 404 potential on refresh of state #3768
Conversation
can we check a status code here? Does it provide a |
@catsby testing this now... |
…ual 404 status code
@catsby you are indeed correct - just changed to the 404 status code:
|
Awesome! I think I mentioned this in another PR (well, I know I did, but I lose track of which are yours since you've sent so many 😄 ) but we should log that we couldn't find the specific If you could tack that on, we'll merge this |
@catsby sorry! Added now :) |
provider/digitalocean: Fixing the DigitalOcean Droplet 404 potential on refresh of state
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Fixes #3670
Changing the DigitalOcean Droplet resource to use the new SDK message response when a Droplet isn't found
Current behavious in master:
Then changing the code to cater for the new API lets me do the following: