Check HTTP status codes on responses from the DigitalOcean API instead of doing string compares #4179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error string for 404s on DNS domains has (apparently) changed, causing things to be a little sad when you modify DNS domains from the DO console instead of terraform. This is just the same fix as was applied to droplets around this time last month. While I was at it I just fixed this everywhere I saw it in the DO provider source tree.
bearcage
changed the title
|
@aberghage this is great - nice addition :) I've run all of the DO tests today and they seem ok |
catsby
added a commit
that referenced
this pull request
Dec 7, 2015
…s_404 Check HTTP status codes on responses from the DigitalOcean API instead of doing string compares
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to #3768 -- just for DNS and keys.
The error string for 404s on DNS domains has (apparently)
changed, causing things to be a little sad when you modify
DNS domains from the DO console instead of terraform. This
is just the same fix as was applied to droplets around this
time last month.
While I was at it I just fixed this everywhere I saw it in the
DO provider source tree.
NB. I didn't run the acceptance tests on this (it's late where
I am, and I wanted to open this while it was still on my mind).
I did however confirm that for my project I was able to
reprovision DNS entries where I'd previously crashed out.