Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_route53_health_check does not support turning on SNI support via EnableSNI #8502

Closed
ziggythehamster opened this issue Aug 26, 2016 · 2 comments

Comments

@ziggythehamster
Copy link

Terraform Version

0.7.1 (0.7.2 is also affected if I look at the source code)

Affected Resource(s)

  • aws_route53_health_check

Expected Behavior

The aws_route53_health_check resource should support an enable_sni attribute (with possible values true and false, where false is the default).

Actual Behavior

The aws_route53_health_check resource does not support enable_sni, which means that HTTPS/SSL endpoints that require SNI cannot be health checked (they will always return unhealthy) unless you make a change using the AWS API or console yourself.

Steps to Reproduce

  1. Create a health check pointing at a HTTPS endpoint that uses SNI.
  2. Observe the health check is always unhealthy.
  3. In the console, toggle the "Enable SNI" checkbox to checked.
  4. Observe the health check works now.

Important Factoids

I don't know Go, but this looks fairly simple to add. The docs show that it's EnableSNI with values true|false.

@paddycarver paddycarver self-assigned this Nov 2, 2016
paddycarver added a commit that referenced this issue Nov 2, 2016
In #8502 it was requested that we add support for the EnableSNI
parameter of Route53's health checks; this enables customers to
manually specify whether or not the health check will use SNI when
communicating with the endpoint.

The customer originally requested we default to `false`. While
implementing the issue, I discovered that when creating health
checks with a Type set to HTTP, Amazon's default value for EnableSNI
is `false`. However, when creating health checks with a Type set to
HTTPS, Amazon's default value is `true`. So rather than setting a
default value, I made the attribute computed.
@stack72
Copy link
Contributor

stack72 commented Nov 3, 2016

Closed via #9822 :)

@stack72 stack72 closed this as completed Nov 3, 2016
gusmat pushed a commit to gusmat/terraform that referenced this issue Dec 6, 2016
In hashicorp#8502 it was requested that we add support for the EnableSNI
parameter of Route53's health checks; this enables customers to
manually specify whether or not the health check will use SNI when
communicating with the endpoint.

The customer originally requested we default to `false`. While
implementing the issue, I discovered that when creating health
checks with a Type set to HTTP, Amazon's default value for EnableSNI
is `false`. However, when creating health checks with a Type set to
HTTPS, Amazon's default value is `true`. So rather than setting a
default value, I made the attribute computed.
@ghost
Copy link

ghost commented Apr 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants