datadog_monitor tags overwritten

[nyanshak]

Terraform Version

Terraform v0.7.5

Affected Resource(s)

• datadog_monitor

The tags for Datadog monitors are for filtering, and are implemented in terraform as a map, but I think it should be a list instead to better match Datadog's API.

builtin/providers/datadog/resource_datadog_monitor.go:

terraform/builtin/providers/datadog/resource_datadog_monitor.go

Lines 265 to 269 in 0475157

	tags := make(map[string]string)
	for _, s := range m.Tags {
	tag := strings.Split(s, ":")
	tags[tag[0]] = tag[1]
	}

These lines split the tag on colon and add to a map, but this behavior is not correct if you have (for example):

• example_tag:value1
• example_tag:value2

This is valid in Datadog, but only the second value will be added to the terraform resource, since it's a map instead of an array.

This can result in terraform overwriting tags that should be tracked.

[ojongerius]

@stack72 you've merged #10570. Users will get errors if they do not update their configs. What do you think is the best way forward: just updating the changelog with a warning, or should we give a warning when the config has a map, instead of the list we expect?
When this provider was external I've done similar things with breaking changes as a courtesy to users. Not sure what is common in Terraform.

[stack72]

Hi @ojongerius

I think we should note this in the incompatibilities section of the changelog. The reason I merged this was because we are about to go to 0.8 and it seemed like it was the right place to make the change (major version)

Do you think something like this:

provider/datadog: datadog_monitor should be a map now and no longer a list

?

[jaygorrell]

@stack72 That's backwards, but otherwise that should be fine.

[stack72]

Hi

Do we still think this is an error? It's been 2 months since this was reported and released

Paul

[nyanshak]

This seems to be properly addressed by 81799b4. Closing

[ojongerius]

🎉

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.