terraform: when promoting non-CBD to CBD, mark the config as such #10455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellh
force-pushed
the
b-non-cbd-promote
branch
from
b78bfa1 to
b093293
Compare
jbardin
approved these changes
Dec 2, 2016
Fixes #10439 When a CBD resource depends on a non-CBD resource, the non-CBD resource is auto-promoted to CBD. This was done in cf3a259. This PR makes it so that we also set the config CBD to true. This causes the proper runtime execution behavior to occur where we depose state and so on. So in addition to simple graph edge tricks we also treat the non-CBD resources as CBD resources.
This brings the change for the new graph. See #10455
mitchellh
force-pushed
the
b-non-cbd-promote
branch
from
b093293 to
95239a7
Compare
|
Split the commits so that we can cherry pick back to 0.7. |
gusmat
pushed a commit
to gusmat/terraform
that referenced
this pull request
Dec 6, 2016
This brings the change for the new graph. See hashicorp#10455
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10439
This fix is backported to legacy graphs, too.
When a CBD resource depends on a non-CBD resource, the non-CBD resource
is auto-promoted to CBD. This was done in
cf3a259. This PR makes it so that we
also set the config CBD to true. This causes the proper runtime
execution behavior to occur where we depose state and so on.
So in addition to simple graph edge tricks we also treat the non-CBD
resources as CBD resources.
As part of this process, I realized that the new graph doesn't support
this at all since there was no context test covering it! I added a
context test. This test also reproduced the error message in #10439
withou the config setting logic, so it shows it fixes that as well.