Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Merge respects Terraform blocks, provider aliases, and more #10720

Merged
merged 2 commits into from
Dec 14, 2016

Conversation

mitchellh
Copy link
Contributor

@mitchellh mitchellh commented Dec 14, 2016

Fixes #10715

config.Merge was not updated to support a number of new features. This
updates the codepath to merge various fields, including the terraform
block which was the issue in #10715.

This also updates config.Append to support terraform blocks. This could
cause the terraform block to be removed with multiple files present. Oy!

The Merge API is called when an _override file is present to merge
configurations. Normally configurations are appended. Only an override
file triggers a merge.

I started working on a generic library to do this automatically awhile
back but never finished it. This might motivate me to do so. In the
interest of getting a fix out though, we'll continue the manual
approach.

Fixes #10715

`config.Merge` was not updated to support a number of new features. This
updates the codepath to merge various fields, including the `terraform`
block which was the issue in #10715.

The `Merge` API is called when an `_override` file is present to _merge_
configurations. Normally configurations are _appended_. Only an override
file triggers a _merge_.

I started working on a generic library to do this automatically awhile
back but never finished it. This might motivate me to do so. In the
interest of getting a fix out though, we'll continue the manual
approach.
@mitchellh mitchellh requested a review from jbardin December 14, 2016 05:55
@mitchellh mitchellh merged commit 8a6b267 into master Dec 14, 2016
@mitchellh mitchellh deleted the b-merge branch December 14, 2016 21:49
@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

required_version has no effect
2 participants