Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate between lookup failure and value inequality. #11218

Merged
merged 1 commit into from
Jan 15, 2017

Conversation

sean-
Copy link
Contributor

@sean- sean- commented Jan 15, 2017

Before this patch it was not possible to test for a key in a map where
the value is an empty string. With this patch, however, it is now
possible to write a check like:

resource.TestCheckResourceAttr("res.name", "mymap.KeyWithEmptyValue", ""),

To test that KeyWithEmptyValue is a valid key in mymap. After an offline convo re: this, I'm going to submit this as a PR for review.

Before this patch it was not possible to test for a key in a map where
the value is an empty string.  With this patch, however, it is now
possible to write a check like:

```
resource.TestCheckResourceAttr("res.name", "mymap.KeyWithEmptyValue", ""),
```

To test that `KeyWithEmptyValue` is a valid key in `mymap`.
@sean- sean- requested review from stack72 and jen20 January 15, 2017 22:54
@jen20 jen20 merged commit b4eda2f into master Jan 15, 2017
@jen20 jen20 deleted the f-improve-test-function branch January 15, 2017 22:59
Copy link
Contributor

@jen20 jen20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup this has bitten me before. Good idea.

@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants