Correct aws_s3_bucket_object data source acceptance tests #11346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love PRs that help make tests better :) LGTM! |
pielu
pushed a commit
to pielu/terraform
that referenced
this pull request
Jan 24, 2017
* commit '439b5507bbe9b00c7154d5b30dd9e35600ef05a2': (688 commits) Update CHANGELOG.md provider/aws: Added API GW documentation regarding request/response templates (hashicorp#11380) Update CHANGELOG.md provider/aws: Added a S3 Bucket domain name attribute (hashicorp#10088) provider/postgresql: Fix failing acceptance test (hashicorp#11375) provider/heroku: Fix failing acceptance test (hashicorp#11374) provider/aws: Fix acceptance tests w/ missing values (hashicorp#11377) provider/aws: Fix failing ecs acceptance test w/ ALB (hashicorp#11367) fix fat-fingered change in test provider/aws: Add diff suppress function for aws_db_instance Update CHANGELOG.md provider/openstack: Volume Attachment Updates (hashicorp#11285) Update CHANGELOG.md adding (backwards compatible) support for providing multiple source filename and content (hashicorp#11271) Correct aws_s3_bucket_object data source acceptance tests. (hashicorp#11346) Update CHANGELOG.md Add 'aws_vpc_endpoint' data source. (hashicorp#11323) Update CHANGELOG.md Add 'aws_canonical_user_id' data source. (hashicorp#11332) Update CHANGELOG.md ...
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11345.
Add
resource.TestCheckNoResourceAttr()which ensures that NO value exists in state for the given name/key combination.