-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/pagerduty: Setting incident_urgency_rule as optional #12211
Merged
stack72
merged 1 commit into
hashicorp:master
from
heimweh:optional-incident_urgency_rule
Feb 23, 2017
Merged
provider/pagerduty: Setting incident_urgency_rule as optional #12211
stack72
merged 1 commit into
hashicorp:master
from
heimweh:optional-incident_urgency_rule
Feb 23, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heimweh
changed the title
[WIP] provider/pagerduty: Setting incident_urgency_rule as optional
provider/pagerduty: Setting incident_urgency_rule as optional
Feb 23, 2017
LGTM
|
stack72
pushed a commit
that referenced
this pull request
Feb 23, 2017
catsby
added a commit
that referenced
this pull request
Feb 23, 2017
* master: (499 commits) provider/aws: Fix the panic in ssm_association with parameters (#12215) Setting incident_urgency_rule as optional (#12211) Latest Section (#12151) provider/pagerduty: Import support for service integrations (#12141) command: fix test for new Meta type terraform: InstanceState.Meta is value type interface{} Update CHANGELOG.md flatmap: mark computed list as a computed value in Expand provider/azurerm: Bump AzureRM SDK to v8.0.1-beta (#11866) provider/profitbricks: fmt changes post cherry-pick provider/aws: Add missing SSM Links to documentation nav bar (#12202) update azure_network_interface documentation to say required for ip_configuration (#12185) Profitbricks primary nic fix (#12197) Update CHANGELOG.md Update CHANGELOG.md Update CHANGELOG.md Update CHANGELOG.md provider/aws: Lambda DeadLetterConfig support what was the value of the cluster id which caused the problem Corrected example code, cleared up token confusion (#12177) ...
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Apr 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the
incident_urgency_rule
toOptional
which is currently set asRequired
but according to the resource documentation and the PagerDuty API reference it's an optional.This should resolve #12149