provider/aws: Prevent aws_dms_replication_task panic #12539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #12506 When a replication_task cdc_start_time was specified as an int, it was causing a panic as the conversion to a Unix timestampe was expecting a string ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAwsDmsReplicationTaskBasic' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2017/03/08 22:55:29 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAwsDmsReplicationTaskBasic -timeout 120m === RUN TestAccAwsDmsReplicationTaskBasic --- PASS: TestAccAwsDmsReplicationTaskBasic (1089.77s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 1089.802s ```
stack72
force-pushed
the
b-aws-dms-task-panic
branch
from
ddb2af7 to
8276218
Compare
|
<3 @grubernaut |
stack72
added a commit
that referenced
this pull request
Mar 8, 2017
Fixes: #12506 When a replication_task cdc_start_time was specified as an int, it was causing a panic as the conversion to a Unix timestampe was expecting a string ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAwsDmsReplicationTaskBasic' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2017/03/08 22:55:29 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAwsDmsReplicationTaskBasic -timeout 120m === RUN TestAccAwsDmsReplicationTaskBasic --- PASS: TestAccAwsDmsReplicationTaskBasic (1089.77s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 1089.802s ```
catsby
added a commit
that referenced
this pull request
Mar 8, 2017
…stable * '0-8-stable' of github.com:hashicorp/terraform: Update CHANGELOG.md provider/aws: Prevent aws_dms_replication_task panic (#12539)
yanndegat
pushed a commit
to yanndegat/terraform
that referenced
this pull request
Mar 13, 2017
Fixes: hashicorp#12506 When a replication_task cdc_start_time was specified as an int, it was causing a panic as the conversion to a Unix timestampe was expecting a string ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAwsDmsReplicationTaskBasic' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2017/03/08 22:55:29 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAwsDmsReplicationTaskBasic -timeout 120m === RUN TestAccAwsDmsReplicationTaskBasic --- PASS: TestAccAwsDmsReplicationTaskBasic (1089.77s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 1089.802s ```
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12506
When a replication_task cdc_start_time was specified as an int, it was
causing a panic as the conversion to a Unix timestampe was expecting a
string
It's important to know that the schema was incorrect here - the strip was required for the Parse of the time not an int