-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/aws: Add support for IPv6 to aws_security_group_rule #12645
Conversation
stack72
commented
Mar 13, 2017
•
edited
Loading
edited
339aa56
to
52e77cb
Compare
``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSecurityGroupRule_' ✹ ✭ ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2017/03/13 15:40:39 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSecurityGroupRule_ -timeout 120m === RUN TestAccAWSSecurityGroupRule_Ingress_VPC --- PASS: TestAccAWSSecurityGroupRule_Ingress_VPC (53.36s) === RUN TestAccAWSSecurityGroupRule_Ingress_Protocol --- PASS: TestAccAWSSecurityGroupRule_Ingress_Protocol (85.22s) === RUN TestAccAWSSecurityGroupRule_Ingress_Ipv6 --- PASS: TestAccAWSSecurityGroupRule_Ingress_Ipv6 (87.55s) === RUN TestAccAWSSecurityGroupRule_Ingress_Classic --- PASS: TestAccAWSSecurityGroupRule_Ingress_Classic (50.58s) === RUN TestAccAWSSecurityGroupRule_MultiIngress --- PASS: TestAccAWSSecurityGroupRule_MultiIngress (47.98s) === RUN TestAccAWSSecurityGroupRule_Egress --- PASS: TestAccAWSSecurityGroupRule_Egress (50.48s) === RUN TestAccAWSSecurityGroupRule_SelfReference --- PASS: TestAccAWSSecurityGroupRule_SelfReference (82.45s) === RUN TestAccAWSSecurityGroupRule_ExpectInvalidTypeError --- PASS: TestAccAWSSecurityGroupRule_ExpectInvalidTypeError (0.01s) === RUN TestAccAWSSecurityGroupRule_PartialMatching_basic --- PASS: TestAccAWSSecurityGroupRule_PartialMatching_basic (95.55s) === RUN TestAccAWSSecurityGroupRule_PartialMatching_Source --- PASS: TestAccAWSSecurityGroupRule_PartialMatching_Source (95.65s) === RUN TestAccAWSSecurityGroupRule_Issue5310 --- PASS: TestAccAWSSecurityGroupRule_Issue5310 (45.91s) === RUN TestAccAWSSecurityGroupRule_Race --- PASS: TestAccAWSSecurityGroupRule_Race (697.79s) === RUN TestAccAWSSecurityGroupRule_SelfSource --- PASS: TestAccAWSSecurityGroupRule_SelfSource (96.19s) === RUN TestAccAWSSecurityGroupRule_PrefixListEgress --- PASS: TestAccAWSSecurityGroupRule_PrefixListEgress (97.51s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 1586.248s ```
52e77cb
to
4a19055
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSecurityGroupRule_' ✹ ✭ ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2017/03/13 15:40:39 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSecurityGroupRule_ -timeout 120m === RUN TestAccAWSSecurityGroupRule_Ingress_VPC --- PASS: TestAccAWSSecurityGroupRule_Ingress_VPC (53.36s) === RUN TestAccAWSSecurityGroupRule_Ingress_Protocol --- PASS: TestAccAWSSecurityGroupRule_Ingress_Protocol (85.22s) === RUN TestAccAWSSecurityGroupRule_Ingress_Ipv6 --- PASS: TestAccAWSSecurityGroupRule_Ingress_Ipv6 (87.55s) === RUN TestAccAWSSecurityGroupRule_Ingress_Classic --- PASS: TestAccAWSSecurityGroupRule_Ingress_Classic (50.58s) === RUN TestAccAWSSecurityGroupRule_MultiIngress --- PASS: TestAccAWSSecurityGroupRule_MultiIngress (47.98s) === RUN TestAccAWSSecurityGroupRule_Egress --- PASS: TestAccAWSSecurityGroupRule_Egress (50.48s) === RUN TestAccAWSSecurityGroupRule_SelfReference --- PASS: TestAccAWSSecurityGroupRule_SelfReference (82.45s) === RUN TestAccAWSSecurityGroupRule_ExpectInvalidTypeError --- PASS: TestAccAWSSecurityGroupRule_ExpectInvalidTypeError (0.01s) === RUN TestAccAWSSecurityGroupRule_PartialMatching_basic --- PASS: TestAccAWSSecurityGroupRule_PartialMatching_basic (95.55s) === RUN TestAccAWSSecurityGroupRule_PartialMatching_Source --- PASS: TestAccAWSSecurityGroupRule_PartialMatching_Source (95.65s) === RUN TestAccAWSSecurityGroupRule_Issue5310 --- PASS: TestAccAWSSecurityGroupRule_Issue5310 (45.91s) === RUN TestAccAWSSecurityGroupRule_Race --- PASS: TestAccAWSSecurityGroupRule_Race (697.79s) === RUN TestAccAWSSecurityGroupRule_SelfSource --- PASS: TestAccAWSSecurityGroupRule_SelfSource (96.19s) === RUN TestAccAWSSecurityGroupRule_PrefixListEgress --- PASS: TestAccAWSSecurityGroupRule_PrefixListEgress (97.51s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 1586.248s ```
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |