Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps: Bump terraform-provider-aws@v1.10.0 and aws-sdk-go@v1.12.75 #17428

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 25, 2018

govendor fetch github.com/aws/aws-sdk-go/...@v1.12.75
govendor fetch github.com/terraform-providers/terraform-provider-aws/...@v1.10.0
make test # no errors

@bflad bflad added the dependencies Auto-pinning label Feb 25, 2018
@apparentlymart
Copy link
Contributor

Is there a specific motivation for doing this (e.g user-facing things we should note in the changelog) or is this just a routine dependency catch-up?

I ask mainly because it's hard to think about what to look for in a review here without some context on what we ought to be testing after the upgrade, etc. Fine with upgrading it if we can get a sense of what changes we might expect to see.

@bflad
Copy link
Contributor Author

bflad commented Feb 26, 2018

@apparentlymart sorry I definitely should have included that information when I submitted this. 😢 This falls under the latter category of routine dependency catch-up (in both the provider and AWS SDK). After my own review, there should be no expected bugfixes or enhancements from these upgrades this time. If you'd prefer to not receive these when we cut a release please let me know!

@apparentlymart
Copy link
Contributor

Ahh sorry I didn't notice when I replied that there had been an AWS provider release. I suppose keeping up to date with releases is a good idea so that we can expect similar behavior in the provider and backend.

Go ahead and merge this when you are ready!

@bflad bflad merged commit 7bb2c17 into master Feb 26, 2018
@bflad bflad deleted the v-terraform-provider-aws-v1.10.0 branch February 26, 2018 11:37
@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Auto-pinning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants