Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix needed to be inline with the updated AWS SDK again... #1804

Merged
merged 1 commit into from
May 5, 2015
Merged

Small fix needed to be inline with the updated AWS SDK again... #1804

merged 1 commit into from
May 5, 2015

Conversation

svanharmelen
Copy link
Contributor

Executed a couple of AWS ACC test as well to make sure everything works properly again after this fix…

Executed a couple of AWS ACC test as well to make sure everything works
properly again after this fix…
svanharmelen pushed a commit that referenced this pull request May 5, 2015
Small fix needed to be inline with the updated AWS SDK again...
@svanharmelen svanharmelen merged commit 61509fd into hashicorp:master May 5, 2015
@svanharmelen svanharmelen deleted the b-fix-after-aws-sdk-changes branch May 5, 2015 10:30
@catsby
Copy link
Contributor

catsby commented May 5, 2015

Thanks for fixing the first thing on my list for today 😄 👍

@svanharmelen
Copy link
Contributor Author

@catsby it was my pleasure 😉

@mitchellh
Copy link
Contributor

As noted in #1801 I don't think that this actually fixes things 1:1, we lose EC2 role pickups and other env vars. I'm looking into it.

mitchellh added a commit that referenced this pull request May 5, 2015
catsby added a commit that referenced this pull request May 5, 2015
* master: (113 commits)
  update cHANGELOG
  update cHANGELOG
  update CHANGELOG
  website: network interface for EIP
  Update CHANGELOG.md
  terraform: provisionedby prefixed
  Added the exit code as well...
  terraform: flattenable graphNodeMissingProvisioner
  Fixing a small vet warning introduced by PR #1796
  terraform: run prune destroy on validate
  Added `SharedCredentialsProvider` and `EC2RoleProvider` as well...
  Fixing PR #1804
  providers/aws: chain credentials
  Update CHANGELOG.md
  Add docs for various iam_* resources.
  Add acceptance tests
  Implement AWS IAM resources
  Implement a hash function for string sets
  provider/aws: Shorting retry timeout for Subnets to 2 minutes, from 5
  provider/aws: Shorting retry timeout for Security Groups to 2 minutes, from 5
  ...
@ghost
Copy link

ghost commented May 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants