Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save read data in the refresh state during plan #26285

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Sep 17, 2020

This only changes the refreshed state stored in the plan file. Since the
change is stored in the plan, the applied result would be the same, but
we should still store the refreshed data in the plan file for tools that
consume the plan file.

This will also be needed in order to implement a new refresh command
based on the plan itself.

This only changes the refreshed state stored in the plan file. Since the
change is stored in the plan, the applied result would be the same, but
we should still store the refreshed data in the plan file for tools that
consume the plan file.

This will also be needed in order to implement a new refresh command
based on the plan itself.
@jbardin jbardin requested a review from a team September 17, 2020 21:16
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #26285 into master will decrease coverage by 1.12%.
The diff coverage is 89.47%.

Impacted Files Coverage Δ
backend/local/backend_apply.go 41.09% <ø> (+1.74%) ⬆️
helper/resource/testing_config.go 0.00% <0.00%> (ø)
plans/plan.go 40.00% <ø> (-8.00%) ⬇️
terraform/evaluate.go 50.56% <ø> (-2.18%) ⬇️
backend/local/backend_plan.go 71.81% <100.00%> (-1.76%) ⬇️
configs/module_call.go 69.33% <100.00%> (+1.76%) ⬆️
configs/named_values.go 67.75% <100.00%> (+0.16%) ⬆️
configs/resource.go 81.64% <100.00%> (-0.18%) ⬇️
terraform/context.go 87.87% <100.00%> (+1.41%) ⬆️
terraform/eval_context_builtin.go 74.62% <100.00%> (-2.74%) ⬇️
... and 645 more

@jbardin jbardin changed the title saved read data in the refresh state during plan save read data in the refresh state during plan Sep 17, 2020
@ghost
Copy link

ghost commented Oct 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants