Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

functions: Fix panics in defaults #27979

Merged
merged 2 commits into from
Mar 5, 2021
Merged

functions: Fix panics in defaults #27979

merged 2 commits into from
Mar 5, 2021

Commits on Mar 4, 2021

  1. functions: Fix defaults null collections panic 

    When applying default values to collection types, null collections in
the input should result in empty collections in the output.
    @alisdair
    alisdair committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    178a9b3 View commit details
    Browse the repository at this point in the history

  2. functions: Fix defaults mismatched types fallback 

    We allow primitive fallback values which have mismatched types, but only
if there is a conversion to the target type. Previously we would allow
unsafe conversions (e.g. string to bool), but later had no capacity to
return an error if the conversion failed due to the value of the
fallback being unable to convert to the target type.

This commit makes the more conservative requirement that default
fallback values must have a safe conversion.
    @alisdair
    alisdair committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    66f8d1c View commit details
    Browse the repository at this point in the history