Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add support for Elastic Search #3443

Merged
merged 3 commits into from
Oct 8, 2015

Conversation

radeksimko
Copy link
Member

Closes #3381

FYI @nickschuch

Test plan

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=ElasticSearch' 2>~/tf.log
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=ElasticSearch -timeout 90m
=== RUN   TestAccAWSElasticSearchDomain_basic
--- PASS: TestAccAWSElasticSearchDomain_basic (1448.71s)
=== RUN   TestAccAWSElasticSearchDomain_complex
--- PASS: TestAccAWSElasticSearchDomain_complex (1454.23s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    2902.972s

@pmoust
Copy link
Contributor

pmoust commented Oct 8, 2015

LGTM! Just tested ;) Thanks for this

@catsby
Copy link
Contributor

catsby commented Oct 8, 2015

Tests pass and the code looks good 👍

@nickschuch
Copy link

Thanks @radeksimko! You rock!

(Worked for me!)

@gjohnson
Copy link

gjohnson commented Oct 8, 2015

👍

radeksimko added a commit that referenced this pull request Oct 8, 2015
provider/aws: Add support for Elastic Search
@radeksimko radeksimko merged commit 8364827 into hashicorp:master Oct 8, 2015
@radeksimko radeksimko deleted the f-aws-es branch October 8, 2015 14:06
@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for new Amazon Elasticsearch Service
5 participants