-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: treat refs to unknown set resource attrs as unknown #4840
Merged
phinze
merged 1 commit into
master
from
phinze/interpolate-computed-set-references-properly
Jan 27, 2016
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -519,6 +519,16 @@ func (i *Interpolater) interpolateListAttribute( | |
log.Printf("[DEBUG] Interpolating computed list attribute %s (%s)", | ||
resourceID, attr) | ||
|
||
// In Terraform's internal dotted representation of list-like attributes, the | ||
// ".#" count field is marked as unknown to indicate "this whole list is | ||
// unknown". We must honor that meaning here so computed references can be | ||
// treated properly during the plan phase. | ||
if attr == config.UnknownVariableValue { | ||
return attr, nil | ||
} | ||
|
||
// Otherwise we gather the values from the list-like attribute and return | ||
// them. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Before the above guard, we'd plow right into the list building below even when the whole list was computed and end up returning an empty list, which was wrong. |
||
var members []string | ||
numberedListMember := regexp.MustCompile("^" + resourceID + "\\.[0-9]+$") | ||
for id, value := range attributes { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would a comment help here? Maybe slightly rhetorical since I'm unsure at first glance as an outsider to this PR why this behavior needs to be here. At least covered by tests! :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call - done in 48b172a