Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Capture deps w/ latest version of godep #4957

Merged
merged 1 commit into from
Feb 2, 2016

Conversation

phinze
Copy link
Contributor

@phinze phinze commented Feb 2, 2016

Previous deps merge had been captured by an older version of godep,
updating godep and rerunning...

godep save $(go list ./... | grep -v /vendor/)

...yielded this diff.

New godep also produced a warning to pin to the major Go version
instead of the minor one, which we do here as well.

Previous deps merge had been captured by an older version of godep,
updating godep and rerunning...

    godep save $(go list ./... | grep -v /vendor/)

...yielded this diff.

New `godep` also produced a warning to pin to the major Go version
instead of the minor one, which we do here as well.
@phinze phinze force-pushed the phinze/update-deps-using-recent-godep branch from d7a2501 to 872371d Compare February 2, 2016 18:32
@phinze phinze changed the title deps: Capcture deps w/ latest version of godep deps: Capture deps w/ latest version of godep Feb 2, 2016
@jen20
Copy link
Contributor

jen20 commented Feb 2, 2016

Looks good to me - somewhat concerning that running godep save ./... locally for me did not flag up these changes with v46 of godep though!

phinze added a commit that referenced this pull request Feb 2, 2016
…nt-godep

deps: Capture deps w/ latest version of godep
@phinze phinze merged commit bb4c58a into master Feb 2, 2016
@phinze phinze deleted the phinze/update-deps-using-recent-godep branch February 2, 2016 21:03
@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants