Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Work around HCL's inability to interpret negative numbers #5038

Closed
wants to merge 1 commit into from

Conversation

radeksimko
Copy link
Member

I recently merged #4854 which (to my surprise) caused one of the tests to fail.

The same test was passing ~11 days ago:
https://travis-ci.org/hashicorp/terraform/builds/105195588

I'm thinking that something must have changed in HCL parser.

This is more of a workaround to make tests green again, rather than a solution.

@mitchellh
Copy link
Contributor

I'll take a look at this now...

@mitchellh
Copy link
Contributor

No more need, fixed: hashicorp/hil@dc4cc84

@mitchellh mitchellh closed this Feb 7, 2016
@radeksimko
Copy link
Member Author

Thx, that was quick! 😃

@radeksimko radeksimko deleted the b-negative-nums branch February 7, 2016 20:17
@mitchellh
Copy link
Contributor

No problem. For interest: I'm pretty sure this never worked and our PRs weren't testing properly before. There haven't been any changes to HIL since I extracted from Terraform which had no code changes in itself. No problem though, we support it now. :)

@jen20
Copy link
Contributor

jen20 commented Feb 7, 2016

Interesting. I spent several hours on Friday coming to this conclusion and was going to address it on Monday. Thanks!

@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants