core: Test fix for mismatched diffs from GH-4965 #5227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test presents itself in an awkward manner as part of the AWS test suite rather than the core test suite - this is because you cannot use real providers in context tests because of circular references, and simplistic test providers in that package do not demonstrate the issue. In the interests of getting this fix in quickly and still having regression coverage for it, it was agreed to include the change here instead. Running the test TestAccAWSVPC_coreMismatchedDiffs without the changes in d95ab75 applied leads to the following output: ``` $ make testacc TEST=./builtin/providers/aws TESTARGS="-run TestAccAWSVPC_coreMismatchedDiffs" ==> Checking that code complies with gofmt requirements... /Users/James/Code/go/bin/stringer GO15VENDOREXPERIMENT=1 go generate $(GO15VENDOREXPERIMENT=1 go list ./... | grep -v /vendor/) TF_ACC=1 GO15VENDOREXPERIMENT=1 go test ./builtin/providers/aws -v -run TestAccAWSVPC_coreMismatchedDiffs -timeout 120m === RUN TestAccAWSVPC_coreMismatchedDiffs --- FAIL: TestAccAWSVPC_coreMismatchedDiffs (2.26s) testing.go:148: Step 0 error: Error applying: 1 error(s) occurred: * aws_vpc.test: diffs didn't match during apply. This is a bug with Terraform and should be reported. FAIL exit status 1 FAIL github.com/hashicorp/terraform/builtin/providers/aws 2.281s make: *** [testacc] Error 1 ``` Applying the changes in d95ab75 (pull request GH-4965) yields the following result when running the test: ``` $ make testacc TEST=./builtin/providers/aws TESTARGS="-run TestAccAWSVPC_coreMismatchedDiffs" ==> Checking that code complies with gofmt requirements... /Users/James/Code/go/bin/stringer GO15VENDOREXPERIMENT=1 go generate $(GO15VENDOREXPERIMENT=1 go list ./... | grep -v /vendor/) TF_ACC=1 GO15VENDOREXPERIMENT=1 go test ./builtin/providers/aws -v -run TestAccAWSVPC_coreMismatchedDiffs -timeout 120m === RUN TestAccAWSVPC_coreMismatchedDiffs --- PASS: TestAccAWSVPC_coreMismatchedDiffs (15.17s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 15.183s ``` The test has a rather misleading name ("AWS") such that it is actually run as part of the nightly acceptance testing. The VPC resource is quick and free to create, hence the selection.
|
cc: @phinze on this one |
|
LGTM |
jen20
added a commit
that referenced
this pull request
Feb 20, 2016
core: Test fix for mismatched diffs from GH-4965
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test presents itself in an awkward manner as part of the AWS test suite rather than the core test suite - this is because you cannot use real providers in context tests because of circular references, and simplistic test providers in that package do not demonstrate the issue. In the interests of getting this fix in quickly and still having regression coverage for it, it was agreed to include the change here instead.
Running the test TestAccAWSVPC_coreMismatchedDiffs without the changes in d95ab75 applied leads to the following output:
Applying the changes in d95ab75 (pull request GH-4965) yields the following result when running the test:
The test has a rather misleading name ("AWS") such that it is actually run as part of the nightly acceptance testing. The VPC resource is quick and free to create, hence the selection.