Make use of ComputedWhen in aws_s3_bucket_object #5330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
I think we can cover this behavior in a Lambda function acceptance test? If the update does not propagate across a single apply the "non empty plan after test step" check will fire. |
|
Basically you mean removing the following 8 lines of code? 😉 Once that PR is merged, I'll be happy to attach such minus change to this PR. |
This commit allows "detaching" to be a valid pending state when detaching a volume. Despite being obvious pending state, it also helps in race situations when a volume is implicitly being detached by Nova.
provider/openstack: Add detaching as valid pending state
The top level object was used not the tags within
This commit protects against unsafe typecasting when an instance is updating its network configuration.
…ate-guard provider/openstack: Safely typecast network during instance update
GH-4812 removed reading server.AccessIPv4 and server.AccessIPv6 because, AFAICT, they are not set by Nova. After removal, a user reported that they were no longer able to read IPs from access_ip_v4 and access_ip_v6 on Rackspace. It's possible that Rackspace sets the AccessIPv* attributes, and if that's true, other cloud providers might as well through custom extensions. The priority of how access_ip_v* is set might require some tweaks in the future.
…not-required Lambda S3 object version defaults to '$LATEST' if unspecified
|
Oh HA! Sounds good. 😄 |
provider/openstack: Re-Add server.AccessIPv4 and server.AccessIPv6
provider/aws: `aws_elastisearch_domain` tags not being set correctly.
Helpful when iterating on a drift test.
Eventually I think this assertion could be fanned out to something much
more targeted like:
ExpectAttributeDiff(resource, attr, oldval, newval)
But this is a step in the right direction.
The `description` field is easy to confuse for a nice field to add an arbitrary comment to - and it's surprising that changes to this field force a new resource, so we add a big note about it to point users at tags. Also marked all the other ForceNew attributes on this resource.
acctests: log a line w/ the non-empty plan
provider/aws docs: Mark ForceNew fields, note about description
Acctest info in README was a bit stale since the enhanced contributing guide landed.
README: link off to CONTRIBUTING for acctest info
provider/aws: Add support for updating Lambda function
provider/aws: Guard against Nil Reference in Redshift Endpoints
provider/aws: Document set_identifer requirement for Route53 weighted and failover types
aws: Fix CloudFormation update for parameters & capabilities if not modified
…docs Updated google instance docs with custom instance type
provider/aws validate number of load_balancers before creating aws_ecs_service
ComputedWhen is a long `TODO`d schema feature that allows any field to be marked as computed when some terget field changes. Right now Terraform has no way of invalidating a field until it sees _that_ field changes, but there are plenty of examples of scenarios where one field changing implies that another field is going to be assigned a new value.
radeksimko
force-pushed
the
computed-when-s3-obj
branch
from
bcd2b99 to
341c294
Compare
|
@phinze Would you mind rebasing your branch, so I can update this PR? |
This was referenced May 27, 2016
|
Closing until WIP is at #4846 but it might take more effort to finish. |
|
Any updates on this? Still having this issue using 0.12.21 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment if one tries to use
aws_s3_bucket_objectwith versioning enabled on that bucket, it won't work quite as expected, because theversion_idis updated afterapply.This limitation makes
aws_s3_bucket_objectnot very handy when used in combination withaws_lambda_function.s3_object_version(mapped toaws_s3_bucket_object.version_id).The full Lambda Function update cycle when used w/
aws_s3_bucket_objecttherefore requires twoapplysteps.