provider/openstack: Making Block Device Size Required #5354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `volume_size` of a `block_device` was originally set to Optional, but it's a required parameter in the OpenStack/Nova API. While it's possible to infer a default size of the block device, making it required more closely matches the Nova CLI client as well as provides consistent experience when working with multiple block_devices.
jtopjian
added a commit
that referenced
this pull request
Feb 27, 2016
provider/openstack: Making Block Device Size Required
jtopjian
added a commit
to jtopjian/terraform
that referenced
this pull request
Feb 27, 2016
This commit fixes and cleans up instance block_device configuration. Reverts hashicorp#5354 in that `volume_size` is only required in certain block_device configuration combinations. Therefore, the actual attribute must be set to Optional and later checks done. Doc upates, too.
jtopjian
added a commit
to jtopjian/terraform
that referenced
this pull request
Feb 27, 2016
This commit fixes and cleans up instance block_device configuration. Reverts hashicorp#5354 in that `volume_size` is only required in certain block_device configuration combinations. Therefore, the actual attribute must be set to Optional and later checks done. Doc upates, too.
bigkraig
pushed a commit
to bigkraig/terraform
that referenced
this pull request
Mar 1, 2016
This commit fixes and cleans up instance block_device configuration. Reverts hashicorp#5354 in that `volume_size` is only required in certain block_device configuration combinations. Therefore, the actual attribute must be set to Optional and later checks done. Doc upates, too.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
volume_sizeof ablock_devicewas originally set to Optional,but it's a required parameter in the OpenStack/Nova API. While it's
possible to infer a default size of the block device, making it required
more closely matches the Nova CLI client as well as provides consistent
experience when working with multiple block_devices.
Fixes #5098