provider/google: Fix Pubsub acceptance tests

[evandbrown]

Acceptance tests for Pubsub topics and subscriptions failed after
incorrectly determining that resources were not deleted in the
CheckDestroy phase.

Fixes #5437

[evandbrown]

The CheckDestroy func was interpreting a non-nil error from the Get{Topic,Subscription} calls to mean the topic still existed, when the opposite is true. I removed checking err in favor of checking the first return value (the resource type) as it's easier to read.

What's thoroughly confused me is why this test run passed: https://travis-ci.org/hashicorp/terraform/jobs/108197224

[evandbrown]

In fact, PubSub tests continued to pass after the test I linked above. This is the test where they started to fail. Any thoughts, @lwander?

[phinze]

That test behavior is definitely odd, but these changes look good so I'm going to pull them in so they make the nightly run for tonight. Here's to a hopefully passing suite! 🍻

[lwander]

Here's why: 3eb65f2#diff-5f8e56f07503aa8fcc49a3e77a381794R39

The code wasn't returning the error, and that commit from 19 days ago fixed that, but inadvertently broke the test.

Thanks for getting these fixed, @evandbrown!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.