Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move GCP projece attribute onto resources, inherit from provider #6112

Merged
merged 5 commits into from
Apr 11, 2016
Merged

Move GCP projece attribute onto resources, inherit from provider #6112

merged 5 commits into from
Apr 11, 2016

Commits on Apr 10, 2016

  1. Make GCP provider "project" attribute optional

    @sethvargo
    sethvargo committed Apr 10, 2016
    Configuration menu
    Copy the full SHA
    7e5ca60 View commit details
    Browse the repository at this point in the history

  2. Deprecate unused "region" attribute in gcp global_forwarding_rule

    @sethvargo
    sethvargo committed Apr 10, 2016
    Configuration menu
    Copy the full SHA
    d5a9e9b View commit details
    Browse the repository at this point in the history

  3. Switch the order of gcp buildNetworks func to be more go-like 

    The current implementation returns error as the first parameter, 
but it is usually the last parameter.
    @sethvargo
    sethvargo committed Apr 10, 2016
    Configuration menu
    Copy the full SHA
    fda23a3 View commit details
    Browse the repository at this point in the history

  4. Accept "project" as an attribute to GCP resources 

    This is the first step in removing the config dependency on "project".
This change is backwards-compatible because the value for this new
attribute defaults to the value from the provider.
    @sethvargo
    sethvargo committed Apr 10, 2016
    Configuration menu
    Copy the full SHA
    bacf5ab View commit details
    Browse the repository at this point in the history

  5. Update documentation to include new "project" attribute 

    This commit also normalizes the format we display attributes.
    @sethvargo
    sethvargo committed Apr 10, 2016
    Configuration menu
    Copy the full SHA
    29b0731 View commit details
    Browse the repository at this point in the history