provider/aws: Change aws_elastic_ip_association to have computed parameters

[stack72]

This PR takes the awesome work by @jkinred in #5236 and changes the parameters to be computed. This is being done so we can get this work into 0.6.16 :)

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEIPAssociation' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEIPAssociation -timeout 120m
=== RUN   TestAccAWSEIPAssociation_basic
--- PASS: TestAccAWSEIPAssociation_basic (181.41s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    181.432s

[catsby]

Should this be allocation-id ?

[stack72]

When an EIP is associated with something (ENI, Instance, Public IP etc), it get's an association-id. This was used as the ID. Therefore, the call to get the association uses the ID rather than the different scenarios it can be. An association_id will always be specific AFAICT

[catsby]

Ah, I misread and thought allocation was the ID

[catsby]

Looks good so far, I've left some comments that we need addressed or discussed before we can merge. Thanks for taking this up, @stack72 !

[stack72]

Test's still pass as expected:

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEIPAssociation' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEIPAssociation -timeout 120m
=== RUN   TestAccAWSEIPAssociation_basic
--- PASS: TestAccAWSEIPAssociation_basic (163.37s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    163.391s

[catsby]

Good to go here

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.