provider/cloudflare: Add migration for v1 to v4 API libraries #6969
Conversation
| "github.com/mitchellh/cloudflare-go" | ||
| ) | ||
|
|
||
| func resourceAwsCloudFlareRecordMigrateState( |
There was a problem hiding this comment.
Small nit: Cloudflare isn't part of AWS, so I don't think there's a reason to include 'AWS' in the function name.
catsby
force-pushed
the
f-cloudflare-record-migration
branch
from
7c02f73 to
6bd8391
Compare
|
Code LGTM - is there a way to wrap a test or three around this? |
catsby
changed the title
catsby
force-pushed
the
f-cloudflare-record-migration
branch
3 times, most recently
from
42a8936 to
2799b1e
Compare
- mock out api calls
catsby
force-pushed
the
f-cloudflare-record-migration
branch
from
2799b1e to
dc6e02e
Compare
catsby
changed the title
| }, | ||
| Expected: "12342092cbc4c391be33ce548713bba3", | ||
| ShouldFail: true, | ||
| }, |
There was a problem hiding this comment.
Nice!
Looks like these exercise TTL and Priority matching - need another pair for exercising the "proxied" logic too?
|
One test Q and one cranky |
|
Sorry for the run-around; I added a test case for [not]proxied and fixed the |
|
👍 LGTM pending travis |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Fixes #6620 by providing a migration from records created with the old library and v1 of the API, to the new library with v4. Unfortunately we have no way of doing this on CloudFlare's side (can't query for the new version of a given ID), so we have to manually match against the records.
TODO: