Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic implementation for remote state on azure #7064

Merged
merged 6 commits into from
Jun 10, 2016
Merged

Add basic implementation for remote state on azure #7064

merged 6 commits into from
Jun 10, 2016

Conversation

Bowbaq
Copy link
Contributor

@Bowbaq Bowbaq commented Jun 8, 2016

This adds a new azure backend for storing the state remotely. This assumes the resource group, storage account & container already exist. Credentials are either read from the same environment variables as the azurerm provider, or from the backend configuration.

Tested locally, seems to work fine:

bowbaq@bowbaq-originate [17:12:19] [~/Dropbox/Originate/rms/rms-dcos/platform/azure] [mb-azure-terraform *]
-> % terraform remote config -backend=azure -backend-config="resource_group=dcos" -backend-config="storage_account_name=installer329sqe3m" -backend-config="container_name=terraform" -backend-config="key=terraform.tfstate"
Remote configuration updated
Remote state configured and pulled.

Todo

  • Add acceptance tests

@Bowbaq
Copy link
Contributor Author

Bowbaq commented Jun 9, 2016

-> % make testacc TEST=./state/remote TESTARGS=" -run TestMASClient"
==> Checking that code complies with gofmt requirements...
/Users/bowbaq/Dropbox/Dev/go/bin/stringer
go generate $(go list ./... | grep -v /vendor/)
2016/06/09 16:06:51 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./state/remote -v -run TestMASClient -timeout 120m
=== RUN   TestMASClient_impl
--- PASS: TestMASClient_impl (0.00s)
=== RUN   TestMASClient
--- PASS: TestMASClient (144.37s)
PASS
ok      github.com/hashicorp/terraform/state/remote 144.382s

@Bowbaq
Copy link
Contributor Author

Bowbaq commented Jun 10, 2016

@stack72
Copy link
Contributor

stack72 commented Jun 10, 2016

@Bowbaq this is fantastic! Thanks - just reviewing and testing this now :)

@stack72
Copy link
Contributor

stack72 commented Jun 10, 2016

@Bowbaq is there any reason this was called MAS?

@stack72
Copy link
Contributor

stack72 commented Jun 10, 2016

ok, this looks great. I am going to merge. We are going to rename this to be azure as the storage backend as this goes with the provider work atm

@stack72 stack72 merged commit c98f391 into hashicorp:master Jun 10, 2016
@Bowbaq
Copy link
Contributor Author

Bowbaq commented Jun 10, 2016

Looked like the storage solution in azure is called Microsoft Azure Storage so I shortened it toMAS.

On Friday, June 10, 2016, Paul Stack notifications@github.com wrote:

Merged #7064 #7064.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#7064 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAlvjTxKYEme7xmCu3MqDNJ7J2QCOtAaks5qKZ60gaJpZM4IwffU
.

@stack72 stack72 mentioned this pull request Jun 10, 2016
@ghost
Copy link

ghost commented Apr 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants