provider/azurerm: Bump azure-sdk-for-go to 3.0.0-beta #7420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 as long as the tests still pass, which remains to be seen at the point where I'm writing this. 😀 |
stack72
changed the title
stack72
changed the title
There were breaking changes to CDN Endpoint, CDN Profile and Storage Account The test results of the changes are as follows: ``` make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=TestAccAzureRMCdnProfile' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /vendor/) TF_ACC=1 go test ./builtin/providers/azurerm -v -run=TestAccAzureRMCdnProfile -timeout 120m === RUN TestAccAzureRMCdnProfile_basic --- PASS: TestAccAzureRMCdnProfile_basic (199.61s) === RUN TestAccAzureRMCdnProfile_withTags --- PASS: TestAccAzureRMCdnProfile_withTags (214.24s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 413.855s ``` ``` make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=TestAccAzureRMCdnEndpoint' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /vendor/) TF_ACC=1 go test ./builtin/providers/azurerm -v -run=TestAccAzureRMCdnEndpoint -timeout 120m === RUN TestAccAzureRMCdnEndpoint_basic --- PASS: TestAccAzureRMCdnEndpoint_basic (226.85s) === RUN TestAccAzureRMCdnEndpoint_withTags --- PASS: TestAccAzureRMCdnEndpoint_withTags (269.52s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 496.382s ``` ``` make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=TestAccAzureRMStorageAccount_' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /vendor/) TF_ACC=1 go test ./builtin/providers/azurerm -v -run=TestAccAzureRMStorageAccount_ -timeout 120m === RUN TestAccAzureRMStorageAccount_basic --- PASS: TestAccAzureRMStorageAccount_basic (163.61s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 163.621s ```
stack72
added a commit
that referenced
this pull request
Jun 30, 2016
Fixes #7374 The introduction of the AzureRM SDK 3.0.0-beta means that the `name_servers` for the DNS Zone are returned from the API This PR has a dependency on #7420 being merged first ``` make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=TestAccAzureRMDnsZone_' ==> Checking that code complies with gofmt requirements... /Users/stacko/Code/go/bin/stringer go generate $(go list ./... | grep -v /vendor/) 2016/06/30 15:20:01 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/azurerm -v -run=TestAccAzureRMDnsZone_ -timeout 120m === RUN TestAccAzureRMDnsZone_basic --- PASS: TestAccAzureRMDnsZone_basic (92.42s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 92.444s ```
| properties.Origins = &origins | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Noting for history that this field is changing from updateable to ForceNew, which is why this block goes away. The field is marked as ForceNew above.
|
Okay gave this a look. LGTM 👍 |
stack72
added a commit
that referenced
this pull request
Jun 30, 2016
Fixes #7374 The introduction of the AzureRM SDK 3.0.0-beta means that the `name_servers` for the DNS Zone are returned from the API This PR has a dependency on #7420 being merged first ``` make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=TestAccAzureRMDnsZone_' ==> Checking that code complies with gofmt requirements... /Users/stacko/Code/go/bin/stringer go generate $(go list ./... | grep -v /vendor/) 2016/06/30 15:20:01 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/azurerm -v -run=TestAccAzureRMDnsZone_ -timeout 120m === RUN TestAccAzureRMDnsZone_basic --- PASS: TestAccAzureRMDnsZone_basic (92.42s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 92.444s ```
stack72
added a commit
that referenced
this pull request
Jul 1, 2016
Fixes #7374 The introduction of the AzureRM SDK 3.0.0-beta means that the `name_servers` for the DNS Zone are returned from the API This PR has a dependency on #7420 being merged first ``` make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=TestAccAzureRMDnsZone_' ==> Checking that code complies with gofmt requirements... /Users/stacko/Code/go/bin/stringer go generate $(go list ./... | grep -v /vendor/) 2016/06/30 15:20:01 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/azurerm -v -run=TestAccAzureRMDnsZone_ -timeout 120m === RUN TestAccAzureRMDnsZone_basic --- PASS: TestAccAzureRMDnsZone_basic (92.42s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 92.444s ```
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were breaking changes to CDN Endpoint, CDN Profile and Storage
Account
The test results of the changes are as follows: