Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "helper/schema: Make nested Set(s) in List(s) work" #7436

Merged
merged 1 commit into from
Jun 30, 2016

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Jun 30, 2016

Reverts #7393

@catsby
Copy link
Contributor Author

catsby commented Jun 30, 2016

re: failing tests mentioned in #7393:

TF_ACC=1 go test ./builtin/providers/fastly -v -run=TestAccFastlyServiceV1_gzips_basic -timeout 120m
=== RUN   TestAccFastlyServiceV1_gzips_basic
--- PASS: TestAccFastlyServiceV1_gzips_basic (35.94s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/fastly 35.953s
Test:
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSecurityGroup_Change -timeout 120m
=== RUN   TestAccAWSSecurityGroup_Change
--- PASS: TestAccAWSSecurityGroup_Change (30.74s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    30.763s
Test:

@radeksimko
Copy link
Member

Merge at will, I will see if I can turn the mentioned failures into more abstract (resource-agnostic) test cases.

@phinze
Copy link
Contributor

phinze commented Jun 30, 2016

LGTM - @catsby lets kick off AWS and Fastly suites manually after this lands.

@catsby catsby merged commit a84aa5e into master Jun 30, 2016
@catsby catsby deleted the revert-7393-b-schema-set-in-list branch June 30, 2016 15:48
catsby added a commit that referenced this pull request Jun 30, 2016
[origin/master] Revert "helper/schema: Make nested Set(s) in List(s) work" (#7436)
a84aa5e
catsby added a commit that referenced this pull request Jun 30, 2016
[origin/master] Revert "helper/schema: Make nested Set(s) in List(s) work" (#7436)
a84aa5e
@catsby
Copy link
Contributor Author

catsby commented Jun 30, 2016

catsby added a commit that referenced this pull request Jun 30, 2016
[origin/master] Revert "helper/schema: Make nested Set(s) in List(s) work" (#7436)
a84aa5e
catsby added a commit that referenced this pull request Jun 30, 2016
[origin/master] Revert "helper/schema: Make nested Set(s) in List(s) work" (#7436)
a84aa5e
@ghost
Copy link

ghost commented Apr 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants