provider/aws: Allow source_ids in aws_db_event_subscription to be Updatable
#7892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updatable Fixes #7809 This commit adds support for `source_ids` to be updated rather than forcing new each time. Unfortunately, it must range over the difference in the source_ids and add and remove them 1 at a time. AWS does not support batch updating source_ids ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSDBEventSubscription_' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSDBEventSubscription_ -timeout 120m === RUN TestAccAWSDBEventSubscription_basicUpdate --- PASS: TestAccAWSDBEventSubscription_basicUpdate (1277.87s) === RUN TestAccAWSDBEventSubscription_withSourceIds --- PASS: TestAccAWSDBEventSubscription_withSourceIds (1012.96s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 2290.844s ```
| return err | ||
| } | ||
| } | ||
| } |
|
LGTM one small nit |
kwilczynski
pushed a commit
to kwilczynski/terraform
that referenced
this pull request
Aug 18, 2016
… Updatable (hashicorp#7892) * provider/aws: Allow `source_ids` in `aws_db_event_subscription` to be Updatable Fixes hashicorp#7809 This commit adds support for `source_ids` to be updated rather than forcing new each time. Unfortunately, it must range over the difference in the source_ids and add and remove them 1 at a time. AWS does not support batch updating source_ids ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSDBEventSubscription_' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSDBEventSubscription_ -timeout 120m === RUN TestAccAWSDBEventSubscription_basicUpdate --- PASS: TestAccAWSDBEventSubscription_basicUpdate (1277.87s) === RUN TestAccAWSDBEventSubscription_withSourceIds --- PASS: TestAccAWSDBEventSubscription_withSourceIds (1012.96s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 2290.844s ``` * Update resource_aws_db_event_subscription.go
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7809
This commit adds support for
source_idsto be updated rather thanforcing new each time. Unfortunately, it must range over the difference
in the source_ids and add and remove them 1 at a time. AWS does not
support batch updating source_ids