-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Aurora instance failover priority feature #8087
add Aurora instance failover priority feature #8087
Conversation
@@ -148,6 +154,10 @@ func resourceAwsRDSClusterInstanceCreate(d *schema.ResourceData, meta interface{ | |||
createOpts.MonitoringInterval = aws.Int64(int64(attr.(int))) | |||
} | |||
|
|||
if attr, ok := d.GetOk("promotion_tier"); ok { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't needed - there is always a default value - so you can just add the parameter directly to the input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stack72 The new commit moved promotion_tier into the input, is it good to go?
Hi @arcadiatea This LGTM! thanks for your work here :)
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Add Aurora instance level failover priority setting.
rds modify-db-instances --promotion-tier