Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws: Add support for network_mode to aws_ecs_task_definition #8391

Merged
merged 3 commits into from
Aug 23, 2016
Merged

provider/aws: Add support for network_mode to aws_ecs_task_definition #8391

merged 3 commits into from
Aug 23, 2016

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Aug 22, 2016 •
edited
Loading

Fixes #8281

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEcsTaskDefinition_'
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/22 18:12:20 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEcsTaskDefinition_ -timeout 120m
=== RUN   TestAccAWSEcsTaskDefinition_basic
--- PASS: TestAccAWSEcsTaskDefinition_basic (29.02s)
=== RUN   TestAccAWSEcsTaskDefinition_withScratchVolume
--- PASS: TestAccAWSEcsTaskDefinition_withScratchVolume (16.75s)
=== RUN   TestAccAWSEcsTaskDefinition_withEcsService
--- PASS: TestAccAWSEcsTaskDefinition_withEcsService (147.77s)
=== RUN   TestAccAWSEcsTaskDefinition_withTaskRoleArn
--- PASS: TestAccAWSEcsTaskDefinition_withTaskRoleArn (19.49s)
=== RUN   TestAccAWSEcsTaskDefinition_withNetworkMode
--- PASS: TestAccAWSEcsTaskDefinition_withNetworkMode (19.52s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    232.588

@stack72
provider/aws: Add support for network_mode to
73f98c5 
`aws_ecs_task_definition`

Fixes #8281

```

```
make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEcsTaskDefinition_'
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/22 18:12:20 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEcsTaskDefinition_ -timeout 120m
=== RUN   TestAccAWSEcsTaskDefinition_basic
--- PASS: TestAccAWSEcsTaskDefinition_basic (29.02s)
=== RUN   TestAccAWSEcsTaskDefinition_withScratchVolume
--- PASS: TestAccAWSEcsTaskDefinition_withScratchVolume (16.75s)
=== RUN   TestAccAWSEcsTaskDefinition_withEcsService
--- PASS: TestAccAWSEcsTaskDefinition_withEcsService (147.77s)
=== RUN   TestAccAWSEcsTaskDefinition_withTaskRoleArn
--- PASS: TestAccAWSEcsTaskDefinition_withTaskRoleArn (19.49s)
=== RUN   TestAccAWSEcsTaskDefinition_withNetworkMode
--- PASS: TestAccAWSEcsTaskDefinition_withNetworkMode (19.52s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	232.588
@stack72 stack72 force-pushed the aws-ecs-networkmode branch from f9a3b7f to 73f98c5 Compare August 23, 2016 08:11
jen20
jen20 reviewed Aug 23, 2016
View reviewed changes
website/source/docs/providers/aws/r/ecs_task_definition.html.markdown
@@ -52,7 +52,8 @@ The following arguments are supported:

* `family` - (Required) The family, unique name for your task definition.
* `container_definitions` - (Required) A list of container definitions in JSON format. See [AWS docs](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/create-task-definition.html) for syntax. Note, you only need the containerDefinitions array, not the parent hash including the family and volumes keys.
* `task_role_arn` - (Optional) The ARN of IAM role that allows your Amazon ECS container task to make calls to other AWS services.
* `task_role_arn` - (Optional) The ARN of IAM role that allows your Amazon ECS container task to make calls to other AWS services.
* `network_mode` - (Optional) The Docker networking mode to use for the containers in the task. The valid values are `none` , `bridge` , and `host`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are extra spaces after commas here, not sure it matters on rendering.

@jen20
Copy link
Contributor

jen20 commented Aug 23, 2016

One (very) minor thing in the docs, other than that LGTM!

@stack72 stack72 merged commit 2f936ea into master Aug 23, 2016
@stack72 stack72 deleted the aws-ecs-networkmode branch August 23, 2016 10:27
c4milo added a commit to hooklift/terraform that referenced this pull request Aug 23, 2016
@c4milo
Merge branch 'master' into f-ebs-detach-on-destroy
a18f95f 
* master: (100 commits)
  Update CHANGELOG.md
  providers/aws: Check error from resourceAwsRoute53RecordBuildSet and return err if set (hashicorp#8399)
  Update CHANGELOG.md
  provider/aws: Add support for ECS svc - LB target group (hashicorp#8190)
  Added example of how the Option settings works (hashicorp#8413)
  Update CHANGELOG.md
  Update CHANGELOG.md
  Update CHANGELOG.md
  provider/aws: Add support for `network_mode` to `aws_ecs_task_definition` (hashicorp#8391)
  Update CHANGELOG.md
  Update CHANGELOG.md
  provider/aws: Add Primary Endpoint Address output for (hashicorp#8385)
  Update CHANGELOG.md
  provider/aws: `aws_elasticache_replication_group_id` validation change (hashicorp#8381)
  provider/google: Remove redundant type declaration
  provider/google: Hook in state migration function
  provider/openstack: docs and tests for allowed_address_pairs
  Update CHANGELOG.md
  website: Docs for AWS API Gateway domain name and base path mapping
  provider/aws: aws_api_gateway_base_path_mapping resource implementation
  ...
@ghost
Copy link

ghost commented Apr 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

networkMode in aws_ecs_task_definition
2 participants
@stack72 @jen20