Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add AWS Billing & Cost Management service account #8701

Merged

Conversation

steveh
Copy link
Contributor

@steveh steveh commented Sep 7, 2016

This adds a very simple data source for the AWS Billing & Cost Management account magic number.

Used to allow AWS to dump detailed billing reports into an S3 bucket you control.

http://docs.aws.amazon.com/awsaccountbilling/latest/aboutv2/billing-getting-started.html#step-2

I'm basing my work off #8221.

As in my first contribution attempt in #8700, I'm new to Go and working blind as I haven't been able to build or test this code. I'm hoping someone who knows what they're doing can check and modify this as needed.

This adds a very simple data source for the AWS Billing account ID magic number.

Used to allow AWS to dump detailed billing reports into an S3 bucket you control.

http://docs.aws.amazon.com/awsaccountbilling/latest/aboutv2/billing-getting-started.html#step-2
@steveh steveh changed the title [WIP] provider/aws: Add AWS Billing & Cost Management service account provider/aws: Add AWS Billing & Cost Management service account Sep 8, 2016
@stack72
Copy link
Contributor

stack72 commented Oct 7, 2016

Hi @steveh

Thanks for the work here - this looks like a nice simple addition :)

Tests are also passing:

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSBillingServiceAccount_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/10/07 13:32:45 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSBillingServiceAccount_ -timeout 120m
=== RUN   TestAccAWSBillingServiceAccount_basic
--- PASS: TestAccAWSBillingServiceAccount_basic (13.45s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    13.485s

@stack72 stack72 merged commit dd66af0 into hashicorp:master Oct 7, 2016
@steveh steveh deleted the feature/aws-billing-service-account branch October 25, 2016 00:43
@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants