Feature CodeCommit Trigger

[sharmaansh21]

Fixes #6973
I deleted my original repo so based on discussion #6980

/cc @stack72

[stack72]

As this is just a reference to a repository, should we validate here? Isn't the validation in the aws_code_commit resource? :)

[stack72]

Hi @optimisticanshul

This is looking good - i have left a few comments inline - nothing bad at all

This will also need some doumentation as well please :)

Paul

[sharmaansh21]

@stack72 Hi i think i took care of most of your comments, so i thinks it's ready for another review :)

[radeksimko]

@optimisticanshul there's a forgotten import which is why Travis is reporting 🔴 :

builtin/providers/aws/resource_aws_codecommit_trigger_test.go:5: imported and not used: "log"

[sharmaansh21]

@radeksimko Updated thanks.

[stack72]

Hi @optimisticanshul

This LGTM! I made 1 change - I removed the test for changes. All it does is just force a new resource so it's fine to be covered by the basic

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSCodeCommitTrigger_'                                                                                                                  ✹
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/09/12 10:52:39 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSCodeCommitTrigger_ -timeout 120m
=== RUN   TestAccAWSCodeCommitTrigger_basic
--- PASS: TestAccAWSCodeCommitTrigger_basic (22.56s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    22.578s

Thanks for all the work here :)

Paul

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.