provider/azurerm: fix computed tags causing non-empty plan

[pmcatominey]

The tag schema was changed in #9199, setting the Computed flag, this was causing
the plan to not be empty for resources which support tags but none were set, as
no value would be set by flattenAndSetTags.

Setting an empty map instead fixes the issue, ran original failing test and an
update tags test to ensure nothing else was broken.

Depends on #9305.

TF_ACC=1 go test ./builtin/providers/azurerm -v -run TestAccAzureRMCdnProfile -timeout 120m
=== RUN   TestAccAzureRMCdnProfile_importWithTags
--- PASS: TestAccAzureRMCdnProfile_importWithTags (171.64s)
=== RUN   TestAccAzureRMCdnProfile_basic
--- PASS: TestAccAzureRMCdnProfile_basic (162.70s)
=== RUN   TestAccAzureRMCdnProfile_withTags
--- PASS: TestAccAzureRMCdnProfile_withTags (203.12s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/azurerm    537.538s

[pmcatominey]

Theres no unit test covering flattenAndSetTags, the reason for which appears to be that we can't get a working instance of ResourceData from outside the schema package.

This could be solved by changing all usages of this function to remove the dependency of that argument, from:

flattenAndSetTags(d, resp.Tags)

To:

d.Set("tags", flattenTags(resp.Tags))

[stack72]

LGTM thanks :)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.