provider/azurerm Fix multiple loadbalancer resource IDs #9401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carinadigital
force-pushed
the
GH-9311
branch
3 times, most recently
from
e686cb8 to
ab95a32
Compare
carinadigital
commented
Oct 17, 2016
| @@ -128,7 +128,18 @@ func resourceArmLoadBalancerProbeCreate(d *schema.ResourceData, meta interface{} | |||
| return fmt.Errorf("Cannot read LoadBalancer %s (resource group %s) ID", loadBalancerName, resGroup) | |||
| } | |||
|
|
|||
| d.SetId(*read.ID) | |||
| var createdProbe_id string | |||
There was a problem hiding this comment.
We could use retrieveLoadBalancerById() here again then findLoadBalancerProbeByName(), but it's another call to the API.
There was a problem hiding this comment.
I think it's fine to read the response here and avoid the additional round trip.
added 8 commits
October 18, 2016 08:33
…b_nat_rule, azurerm_lb_nat_pool.
carinadigital
force-pushed
the
GH-9311
branch
from
ec4af6f to
7b133ad
Compare
added 2 commits
October 18, 2016 09:26
The check for ARM_SUBSCRIPTION_ID breaks the PR testing. The PR testing isn't trying to check acceptance tests anyway. There will still be a correct failure for missing ARM_SUBSCRIPTION_ID when running the acceptance test due to the later testAccPreCheck().
carinadigital
changed the title
|
This is ready for review. Passing tests listed below. |
jen20
approved these changes
Oct 18, 2016
There was a problem hiding this comment.
Hi @carinadigital! Thanks for submitting this pull request. I'm going to merge it for the imminent version of Terraform after making a few local tweaks to the error messages.
| if pool_id != "" { | ||
| d.SetId(pool_id) | ||
| } else { | ||
| return fmt.Errorf("Error can not find created loadbalacner backend address pool id %s", pool_id) |
There was a problem hiding this comment.
loadbalacner => LoadBalancer
| @@ -15,6 +16,11 @@ func TestAccAzureRMLoadBalancerBackEndAddressPool_basic(t *testing.T) { | |||
| ri := acctest.RandInt() | |||
| addressPoolName := fmt.Sprintf("%d-address-pool", ri) | |||
|
|
|||
| subscriptionID := os.Getenv("ARM_SUBSCRIPTION_ID") | |||
There was a problem hiding this comment.
I think we expose this via the provider?
| @@ -128,7 +128,18 @@ func resourceArmLoadBalancerProbeCreate(d *schema.ResourceData, meta interface{} | |||
| return fmt.Errorf("Cannot read LoadBalancer %s (resource group %s) ID", loadBalancerName, resGroup) | |||
| } | |||
|
|
|||
| d.SetId(*read.ID) | |||
| var createdProbe_id string | |||
There was a problem hiding this comment.
I think it's fine to read the response here and avoid the additional round trip.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-9311 and usage of ID property for azurerm loadbalancers including:
azurerm_lb_probe
azurerm_lb_backend_address_pool
azurerm_lb_rule
azurerm_lb_nat_rule
azurerm_lb_nat_pool