Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the docker config is nil, fixes #13371 #13373

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

tomjn
Copy link
Contributor

@tomjn tomjn commented Mar 28, 2024

Sometimes the host network has a nil config, causing a crash on vagrant up when checking the docker networks.

See #13371 for more details of the bug this fixes

Sometimes the host network has a nil config, causing a crash on vagrant up when checking the docker networks
@tomjn
Copy link
Contributor Author

tomjn commented Mar 28, 2024

It looks like network_containing_address in the same file has a similar check that wasn't applied here:

        networks.each do |net|
          next if !net["IPAM"]
          config = net["IPAM"]["Config"]
          next if !config || config.size < 1
          config.each do |opts|

Copy link
Member

@chrisroberts chrisroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chrisroberts chrisroberts merged commit df5d8f1 into hashicorp:main Jul 10, 2024
12 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants