Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logger and ostruct to the gemspec #13499

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Add logger and ostruct to the gemspec #13499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions vagrant.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ Gem::Specification.new do |s|
s.required_rubygems_version = ">= 1.3.6"

s.add_dependency "base64", "~> 0.2.0"
s.add_dependency "logger", "~> 1.6.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should probably be changed to ~>1.0 or ~>1.6, refer to #13527 for more info.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or say ~> 1.6.0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't speak Ruby so I'm not sure (shrugs), I'll leave the judgement to you.

s.add_dependency "ostruct", "~> 0.1.0"
s.add_dependency "bcrypt_pbkdf", "~> 1.1"
s.add_dependency "childprocess", "~> 4.1.0"
s.add_dependency "ed25519", "~> 1.3.0"
Expand Down