Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for VirtualBox 7.1 #13513

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

chrisroberts
Copy link
Member

Adds support for the 7.1.x versions of VirtualBox to the builtin provider plugin.

@justdan96
Copy link

justdan96 commented Oct 29, 2024

This PR appears to be missing this change:


Without this Vagrant will continue to see VirtualBox 7.1 as unsupported.

@hswong3i
Copy link
Contributor

hswong3i commented Oct 29, 2024

Some more miss:

diff --git a/website/content/docs/providers/virtualbox/index.mdx b/website/content/docs/providers/virtualbox/index.mdx
index 6c685971f..96f47151c 100644
--- a/website/content/docs/providers/virtualbox/index.mdx
+++ b/website/content/docs/providers/virtualbox/index.mdx
@@ -12,7 +12,7 @@ Vagrant comes with support out of the box for [VirtualBox](https://www.virtualbo
 a free, cross-platform consumer virtualization product.
 
 The VirtualBox provider is compatible with VirtualBox versions 4.0.x, 4.1.x,
-4.2.x, 4.3.x, 5.0.x, 5.1.x, 5.2.x, 6.0.x, 6.1.x and 7.0.x. Other versions are unsupported and the provider
+4.2.x, 4.3.x, 5.0.x, 5.1.x, 5.2.x, 6.0.x, 6.1.x, 7.0.x and 7.1.x. Other versions are unsupported and the provider
 will display an error message. Please note that beta and pre-release versions
 of VirtualBox are not supported and may not be well-behaved.

@hswong3i
Copy link
Contributor

This PR appears to be missing this change:

Without this Vagrant will continue to see VirtualBox 7.1 as unsupported.

Specifically patch could be:

diff --git a/plugins/providers/virtualbox/driver/meta.rb b/plugins/providers/virtualbox/driver/meta.rb
index 4b1878bde..63af500c6 100644
--- a/plugins/providers/virtualbox/driver/meta.rb
+++ b/plugins/providers/virtualbox/driver/meta.rb
@@ -69,7 +69,6 @@ module VagrantPlugins
             "6.0" => Version_6_0,
             "6.1" => Version_6_1,
             "7.0" => Version_7_0,
+            "7.1" => Version_7_1,
           }
 
           if @@version.start_with?("4.2.14")

hswong3i added a commit to alvistack/hashicorp-vagrant that referenced this pull request Oct 29, 2024
    git clean -xdf
    git submodule sync --recursive
    git submodule update --recursive --init
    git submodule foreach --recursive git clean -xdf
    gem build vagrant.gemspec -o ../vagrant-2.4.1.gem
    bundle config set --local path ./bundle
    bundle install --verbose --standalone
    bundle config set --local cache_all true
    bundle config set --local cache_all_platforms true
    bundle cache
    mv ../vagrant-2.4.1.gem ./vendor/cache/
    rm -rf .bundle bundle vendor/bundle Gemfile.lock
    tar zcvf ../vagrant_2.4.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp vagrant.spec ../vagrant_2.4.1-1.spec
    cp vagrant.rpmlintrc /osc/home\:alvistack/hashicorp-vagrant-2.4.1/
    cp ../vagrant*2.4.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/hashicorp-vagrant-2.4.1/
    rm -rf ../vagrant*2.4.1*.*

See https://salsa.debian.org/ruby-team/vagrant/-/blob/master/debian/patches/0001-bin-vagrant-silence-warning-about-installer.patch
See https://salsa.debian.org/ruby-team/vagrant/-/blob/master/debian/patches/0005-Relax-dependency-resolution.patch
See https://build.opensuse.org/package/show/openSUSE:Factory/vagrant
See hashicorp#13390
See hashicorp#13499
See hashicorp#13513

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
@Insua
Copy link

Insua commented Oct 30, 2024

please release new version as quickly as possible

@chrisroberts chrisroberts merged commit 5e83b54 into hashicorp:main Oct 30, 2024
13 checks passed
@chrisroberts chrisroberts deleted the vbox-7_1 branch October 30, 2024 19:37
@tesla59
Copy link

tesla59 commented Oct 30, 2024

it has been a while since a new vagrant release. when can we expect this to be released?

@chrisroberts
Copy link
Member Author

I'm actively working through the last of the open items I want addressed in this release, so it will be soon. In the meantime, this changeset will be included in the nightly builds (and is included in this dev build that I kicked off earlier).

@daxiangroup
Copy link

Hey @chrisroberts, curious on a ballpark for "soon". I'm not trying to poke the bear here, or tie you to an actual date, just wondering if soon is days or weeks? (I understand there are nightlies...)

@chrisroberts
Copy link
Member Author

@daxiangroup my target is no later than end of day tomorrow.

@daxiangroup
Copy link

@daxiangroup my target is no later than end of day tomorrow.

hero!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants