Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate windows path #7012

Merged
merged 1 commit into from
Jul 19, 2016

Conversation

penguincoder
Copy link
Contributor

@penguincoder penguincoder commented Feb 11, 2016

@dhagberg
Copy link

This appears to solve the problem with vagrant-1.8.1 on Windows 7 x64 in a git-bash 2.7.2 shell with rsync.exe copied from an msys2 installation into /mingw64/bin/rsync.

@blah238
Copy link

blah238 commented Jul 18, 2016

@sethvargo Can we please get this merged? This is a dealbreaker for Windows users.

@sethvargo sethvargo merged commit 8a5cf3b into hashicorp:master Jul 19, 2016
@pgouv
Copy link

pgouv commented Jul 19, 2016

Does this address the issue for cygwin? For window hosts and bsd guests rsync is only viable/easy way

@penguincoder penguincoder deleted the rsync-command-quoting branch July 25, 2016 17:04
@matthew-hickok
Copy link

Did this solve the issue? Previously I would remove the 3 options in lines 77-79 from the helper.rb (which worked). When I upgraded to 1.8.5, I saw the changes to the helper.rb file, and it looks like it should detect the host and when it's a Windows host the 3 problematic options are removed.

So I thought it would work, but the issue persisted. Reverting back to 1.8.4 with those lines removed fixed the issue again.

@penguincoder
Copy link
Contributor Author

Vagrant 1.8.5 has been working great for me with rsync in Windows.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants