-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/virtualbox: Refactor host-only network settings #7699
Conversation
@chrisroberts Could you please review this? |
I've rebased the branch and fixed a merge conflict. |
3077ee3
to
a452f72
Compare
Rebased |
a452f72
to
2f2a678
Compare
2f2a678
to
b79e022
Compare
b79e022
to
d9d0811
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updated the error output to be formatted instead of the raw hash. Otherwise, this looks great! Thanks so much and thanks for the rebases (and patience 😃) Cheers!
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
I've refactored
VagrantPlugins:: ProviderVirtualBox::Action:: Network#hostonly_config
in order to make it more simpler, readable and safer to use:IPAddr
instances, not strings.Use
IPAddr
methods instead ofVagrant::Util::NetforkIP#network_address
and string splitting.private_network
(aka host-only), but the validation could be moved to the global scope if you think it's reasonable. Examples:Existing unit tests for this class are passed. I've also verified it with manual tests on real VMs.