guests/linux: Place ethernet devices at start of device list #7848
Conversation
| # Valid ethernet device prefix values. | ||
| # eth - classic prefix | ||
| # en - predictable interface names prefix | ||
| ETHERNET_PREFIX = ["eth", "en"] |
There was a problem hiding this comment.
And possibly name it something more descriptive like POSSIBLE_ETHERNET_PREFIXES
| result = cap.network_interfaces(machine) | ||
| expect(result).to eq(["enp0s3", "enp0s5", "enp0s8", "bridge0", "docker0"]) | ||
| end | ||
|
|
| @@logger.debug("Unsorted list: #{ifaces.inspect}") | ||
| # Break out integers from strings and sort the arrays to provide | ||
| # a natural sort for the interface names | ||
| ifaces = ifaces.map do |iface| | ||
| unless eth_prefix |
There was a problem hiding this comment.
I know it's Ruby, but neither @mitchellh or I are a fan of the "unless" and much prefer if ! or if .nil? since it mentally maps better to the Golang folks who might look at this code in some future.
|
@sethvargo updated |
|
Hi team, DEBUG network_interfaces: Unsorted list: ["enp0s3", "enp0s8", "docker0"] The outcome is that the private network configuration is applied to docker0 instead of enp0s8. Regards. |
|
@lhernanz Hi and thanks for the update! There have been a few other cases pointed out as well that need some adjustment. I'll be pushing out a new PR with expanded specs and an update shortly. Cheers! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Always provide sorted ethernet devices at the start of the network devices list.
Fixes #7844