Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nodejs 20 #509

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Use nodejs 20 #509

merged 1 commit into from
Dec 22, 2023

Conversation

jfroche
Copy link
Contributor

@jfroche jfroche commented Dec 18, 2023

Node 16 has reached its end of life

More details here: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Did not commit changes to dist/index.js (This is only done for releases by vault-action maintainers)

Community Note

  • Please vote on this pull request by adding a 👍
    reaction
    to the original pull request comment to help the community and maintainers
    prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request
    followers and do not help prioritize the request

Copy link
Contributor

@maxcoulombe maxcoulombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for taking care of that!

@maxcoulombe maxcoulombe merged commit 6853090 into hashicorp:main Dec 22, 2023
2 checks passed
@markmssd
Copy link

Thanks @jfroche ! 🙌🏼

@maxcoulombe out of curiosity, when can we expect a new release with this change?

@fairclothjm
Copy link
Contributor

Did we intentionally not update the Node version in our build and test workflow files? For example,

node-version: '16.14.0'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants