Skip to content

Commit

Permalink
openshift/server: readiness probe passes when server uninitialized
Browse files Browse the repository at this point in the history
Changes the default server readiness probe to pass when the server is
uninitialized, in order to pass the latest version of the
chart-verifier test (see #954) for details.

Also updates the chart-verifier used in our tests to 1.13.0 (latest).
  • Loading branch information
tvoran committed Oct 24, 2023
1 parent 2473937 commit 7912d87
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ jobs:
chart-verifier:
runs-on: ubuntu-latest
env:
CHART_VERIFIER_VERSION: '1.10.1'
CHART_VERIFIER_VERSION: '1.13.0'
steps:
- uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0
- name: Setup test tools
uses: ./.github/actions/setup-test-tools
- uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0
with:
go-version: '1.19.2'
go-version: '1.21.3'
- run: go install "github.com/redhat-certification/chart-verifier@${CHART_VERIFIER_VERSION}"
- run: bats --tap --timing ./test/chart
permissions:
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Changes:
* Default `vault` version updated to 1.15.0
* Default `vault-k8s` version updated to 1.3.0
* Tested with Kubernetes versions 1.24-1.28
* server: OpenShift default readiness probe returns 204 when uninitialized

Features:
* server: Add support for dual stack clusters [GH-833](https://github.com/hashicorp/vault-helm/pull/833)
Expand Down
3 changes: 3 additions & 0 deletions values.openshift.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,6 @@ server:
image:
repository: "registry.connect.redhat.com/hashicorp/vault"
tag: "1.15.0-ubi"

readinessProbe:
path: "/v1/sys/health?uninitcode=204"

0 comments on commit 7912d87

Please sign in to comment.