-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to configure resource request/limits for vault-agent sidecar #472
Comments
Hi @elcomtik, thanks for the feature request! This is a good feature but will require changes to the Vault Agent Injector. Currently the injector only supports changing the resource settings via annotation, so we would need to add flag/environment variable support in that project first because we can add Helm configurables. I opened an issue in Vault K8s for this: hashicorp/vault-k8s#238 |
@jasonodonnell Thanks for taking action. |
@elcomtik This feature was implemented and merged in Vault K8s. We'll expose these in Vault Helm so they're configurable. |
Great to hear that. |
It looks like this functionality is now exposed in v0.11.0. Should this be closed? |
Yes, I'm closing it. Thanks a lot. |
I don't see the Related issue: hashicorp/vault#11572 |
Thanks @SohamJ, they are documented but an error with auto-publishing to the website prevented them from going live (PR here: hashicorp/vault#11355). We'll get this updated today along with the release of Vault Helm 0.12.0 |
You can find these on the website now. Vault Helm 0.12.0 is delayed slightly but the documentation is now updated. Thanks again! |
Is your feature request related to a problem? Please describe.
When I use multiple deployments with vault-injector, vault-agent sidecar requests an additional 250m/64Mi per pod. Actually, it consumes only 2m/13Mi. This may seem insignificant, however, summed together it may be a lot of wasted resources.
Describe the solution you'd like
I would like to have the option to configure resource request/limits for vault-agent sidecar the same way as it is configurable for vault-injector itself. Currently, I didn't found any option to set these values.
Additional context
Part of my test pod yaml definition, which includes added vault-agent sidecar.
The text was updated successfully, but these errors were encountered: